🎉 Basic treasury structure intro (no functionality, just basic hello world structure)#168
🎉 Basic treasury structure intro (no functionality, just basic hello world structure)#168garry-sharp wants to merge 1 commit intofees-v3-rebroadcastfrom
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the basic treasury plugin structure to the project, adding configuration, Docker containerization, and core plugin functionality without implementing actual business logic.
- Adds treasury plugin Go code with basic interface implementations
- Creates Docker configurations for treasury server and worker services
- Establishes database and Redis infrastructure for treasury operations
Reviewed Changes
Copilot reviewed 23 out of 31 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin/treasury/*.go | Core treasury plugin implementation with config, handlers, and interface compliance |
| cmd/treasury/* | Main entry points for treasury server and worker applications |
| treasury.*.example.json | Example configuration files for treasury services |
| dockerfiles/Dockerfile.Treasury.* | Docker build configurations for treasury components |
| docker-compose*.yaml | Service definitions and volume configurations for treasury infrastructure |
| init-scripts/01_create_vultisig_plugin.sql | Database creation script for treasury |
| etc/vultisig/treasury.yml | Treasury-specific configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| logger logrus.FieldLogger, | ||
| verifierApi *verifierapi.VerifierApi, | ||
| ) (*TreasuryPlugin, error) { | ||
| var jobMutex sync.Mutex |
There was a problem hiding this comment.
The jobMutex variable is declared locally but never used. It should be removed since the struct field jobMutex is properly initialized with the passed parameter.
docker-compose.yaml
Outdated
| redis-fees: | ||
| condition: service_healthy |
There was a problem hiding this comment.
The treasury-server service depends on redis-fees but should depend on redis-treasury since it uses REDIS_HOST: redis-treasury.
garry-sharp
force-pushed
the
treasury-v1-core
branch
from
bd14711 to
2e94fe7
Compare
…world structure) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
garry-sharp
force-pushed
the
treasury-v1-core
branch
from
2e94fe7 to
722fca5
Compare
garry-sharp
force-pushed
the
fees-v3-rebroadcast
branch
from
5da5bc6 to
6c03da4
Compare
1 participant
No description provided.